Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To discuss: Does anyone have other or better approaches for bottom-up implementation? #26

Open
nathalie-ckc opened this issue Jul 10, 2018 · 4 comments

Comments

@nathalie-ckc
Copy link
Contributor

Per discussion in the 2nd Composables call, creating "to do" items in Github Issues for areas where we could use help from devs who want to contribute.

This question comes from the 3rd Composables call.

@niusealeo
Copy link

niusealeo commented Feb 4, 2020

I think it would be a good idea to break down the ComposablesBottomUp and ComposablesTopDown contract implementations into separate files for each of NFT ERC721 and FT ERC20/223 composable elements.
Then provide example contracts that inherit each of the broken down granular contracts to create contracts with functionality equivalent to the current all-inclusive examples. This will make it easier for developers exploring this module to mix and match their preferred features without having to do too much copy paste.

@mudgen
Copy link
Collaborator

mudgen commented Feb 4, 2020

@viltiki I agree with you. Such an implementation would be welcome.

@qbig
Copy link

qbig commented Feb 18, 2022

as per https://github.com/ethereum/EIPs/blob/master/EIPS/eip-998.md, is ERC998ERC20BottomUp missing here? @mudgen

@qbig
Copy link

qbig commented Feb 18, 2022

ERC20 Bottom-Up Composable interesting decision to make ERC998ERC20BottomUp an ERC20 token in itself? But what if we want to allow vanila ERC721 to own valina ERC20 tokens?
Or do we have to use of combination of ERC998ERC721BottomUp+ERC998ERC20TopDown to achieve this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants