Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created file type not getting shared in the channel #1

Open
AayushChaudhary0001 opened this issue Jul 10, 2024 · 9 comments
Open

Created file type not getting shared in the channel #1

AayushChaudhary0001 opened this issue Jul 10, 2024 · 9 comments

Comments

@AayushChaudhary0001
Copy link

During testing of this plugin, I found a bug which is not consistent.

When a user runs the command to create a doc/slide/sheet, and checks the checkbox to share it to the channel as well, the file type is not always shared on the channel.

Steps to reproduce:-

  • Run the "/drive create < desired file type >" .
  • Fill the mandatory fields and check the channel sharing checkbox.
  • Open the channel where the file was shared.

The shared file is not getting reflected in the channel

Note:- This bug is not consistent, you might not be able to reproduce it every time.

@darkLord19
Copy link
Contributor

Can you share some logs or approx steps which can help me reproduce this issue? @AayushChaudhary0001

@wiggin77
Copy link
Collaborator

@AayushChaudhary0001 can you provide the information requested?

@AayushChaudhary0001
Copy link
Author

@darkLord19 I tried to reproduce this and I have created a video for the same, which I am attaching below, please have a look.

Bug.mp4

I am also adding the logs which I am receiving below.

{"timestamp":"2024-07-31 11:08:44.975 Z","level":"error","msg":"something went wrong while updating permissions for file","caller":"app/plugin_api.go:940","plugin_id":"com.darklord.plugin-google-drive","err":"googleapi: Error 403: The user does not have sufficient permissions for this file., insufficientFilePermissions","fileID":"1pLyqJJCmAfoPWNBRo05ayLkRtDGlD6YiM-nbljbFuEw"}
{"timestamp":"2024-07-31 11:08:45.259 Z","level":"error","msg":"Owner of the file performed this action","caller":"app/plugin_api.go:940","plugin_id":"com.darklord.plugin-google-drive","pageToken":"94617"}
{"timestamp":"2024-07-31 11:08:44.976 Z","level":"error","msg":"failed to modify file permissions","caller":"app/plugin_api.go:940","plugin_id":"com.darklord.plugin-google-drive","err":"googleapi: Error 403: The user does not have sufficient permissions for this file., insufficientFilePermissions"}

Please have a look at these of they can help, also let me know if I am missing something from my end.

@darkLord19
Copy link
Contributor

@AayushChaudhary0001 can you share which apis have you enabled for you gcp project? Also can you tell me if you are able to update permission of file to anyone manually for the doc using the same account you have used for mm connection?

@AayushChaudhary0001
Copy link
Author

@darkLord19 Yes I am able to update the permission type manually for the doc using the same account.

@darkLord19
Copy link
Contributor

@AayushChaudhary0001 can you pull this branch #11 and use it to test this feature again? Also clear all the data from previous plugin, disconnect and connect your account again

@BenCookie95
Copy link
Contributor

@AayushChaudhary0001 Can you confirm what apis were enabled when this was failing? This is difficult to reproduce.

Did the branch from @darkLord19 resolve the issue for you?

@AayushChaudhary0001
Copy link
Author

@darkLord19 @BenCookie95 This branch #11 seems to be deleted without merge, can you please let me know form where I can re-test this issue?

@BenCookie95
Copy link
Contributor

Upon further investigation we found that org level permissions are impacting this, their org has certain sharing options disabled. We need to investigate if we can fetch the org permissions and only display the applicable options to them in the create doc modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants