Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

innerHeigth() <> heigth() #23

Open
boomsya opened this issue Dec 14, 2018 · 1 comment
Open

innerHeigth() <> heigth() #23

boomsya opened this issue Dec 14, 2018 · 1 comment

Comments

@boomsya
Copy link

boomsya commented Dec 14, 2018

hi. i try to use plugin
but i have some problem - selected objectsjQuery('.pg-csv-box').equalHeights();have real max height 291px but plugin returns 316px because objects with margin and padding.

when i modied plugin to show height and innerheight:

console.log(height);
console.log('height'+$(this).height());

it was returned:

316
height291
311
height286
310
height285

then i modified src to var height = $(this).height(); and height at now calculated OK

//sorry for scary english :)

@mattbanks
Copy link
Owner

If you'd like to submit a PR, please do! I haven't used this myself in a long time, so I haven't looked at the code (I use flexbox to ensure equal height boxes now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants