Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging SideBarItemConfig with MainItemConfig #535

Open
patrickacollier opened this issue Jul 23, 2024 · 1 comment
Open

Merging SideBarItemConfig with MainItemConfig #535

patrickacollier opened this issue Jul 23, 2024 · 1 comment

Comments

@patrickacollier
Copy link

@matt8707 curious what your thoughts are, or how you thought about handling the components that are only available to sidebar. Do you think SidebarItemConfig and MainItemConfig should be refactored into 1?
If separate, how would you imagine handling the content rendering?

I've created a PR (on my local) just to see what all it would take (this is keeping both Main and Sidebar config). I've only implemented "Bar" from sidebar but all objects are available and editable. But determining the best way to display the content as they are implemented differently.

Also this is my first svelte project, so just a few hours in. open for any suggestions.
image
*also, with this test you can't actually edit the component once its created likely due to the differences in sidebar/main implements.

@matt8707
Copy link
Owner

Yeah, there will be small (or large) differences in how the component looks and behaves depending on whether it's in the sidebar or main section. To stay sane while prototyping, they're split up for now. However, the plan is to merge them further down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants