Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixRTCSessionManager keeps logging on error level #3781

Open
finsterwalder opened this issue Oct 4, 2023 · 2 comments
Open

MatrixRTCSessionManager keeps logging on error level #3781

finsterwalder opened this issue Oct 4, 2023 · 2 comments

Comments

@finsterwalder
Copy link
Contributor

finsterwalder commented Oct 4, 2023

@dbkr added new code to MatrixRTCSessionManager in this commit: 6836720

private onRoomState = (event: MatrixEvent, _state: RoomState): void => {
const room = this.client.getRoom(event.getRoomId());
if (!room) {
logger.error(`Got room state event for unknown room ${event.getRoomId()}!`);
return;
}

This keeps logging error messages. Obviously the event is processed, before the new room is known by the client.
This should be handled more gracefully, because it seams to be a "normal" situation.
And maybe it needs to be changed, so that the needed processing is done, after the room was created?

@jgarplind
Copy link
Contributor

I tracked down error logs to the same place.

We don't use WebRTC, but because of this, we are still impacted:

        // NB. We initialise MatrixRTC whether we have call support or not: this is just
        // the underlying session management and doesn't use any actual media capabilities
        this.matrixRTC = new MatrixRTCSessionManager(this);

This can of course be filtered on our side, but I agree with OP that a more graceful handling from the SDK would be ideal.

@finsterwalder
Copy link
Contributor Author

I would be willing to provide a patch, but need someone to discuss, what the "correct" solution would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants