Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Signer implementation #1366

Open
3 tasks
thomas-senechal opened this issue Aug 29, 2024 · 0 comments
Open
3 tasks

Fix Signer implementation #1366

thomas-senechal opened this issue Aug 29, 2024 · 0 comments
Assignees

Comments

@thomas-senechal
Copy link
Member

Context
The current implementation of Signer is broken. It is supposed to allow us to do multiple implementations of signers to be able to sign, for example, using Massa Wallet, a Secret Key from env etc. We only used it for MW in MS, and overtime, things got mixed up and the implementation is now tied to MW.

We need to modify the implementation to allow more modularity and ensure that any kind of Signer implementation is possible.

How to

QA testing

  • Download MS
  • Install MS
  • Install MW
  • Try to do some operations on buildnet
  • Everything should work fine
@thomas-senechal thomas-senechal self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant