Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve node/network config #1317

Open
Thykof opened this issue Jan 8, 2024 · 1 comment
Open

improve node/network config #1317

Thykof opened this issue Jan 8, 2024 · 1 comment

Comments

@Thykof
Copy link
Contributor

Thykof commented Jan 8, 2024

          Can't we combine those structs ? 

They are the same except for the fields names, but we could move the yaml specs of NetworkConfig to NetworkInfos

Well, in NetworkConfig, we have URLs that is an array of strings, but it looks like we are always using the first url of the array. So I guess we can use a simple string.
It is not modifiable by users, so there are no issue removing the possibility to have multiple URLs.

IMO, we shouldn't even name those things "Networks" but simply "Nodes". Because, ATM, users can't add custom nodes to the list (as we embed the list inside MS), but as a user, I'd like to be able to add my own node, maybe a local one, or one that is on a remote server, but it will still be connected to Mainnet (or buildnet or testnet....)
So I can have 2 instances of "Mainnet", but one is my node, and one is a node from Massa. And so if for example, my node is down for a maintainance, but I need to connect to MS, I can use Massa's one.

Definetly not something to do in this PR, but maybe we should open an issue on the subject.

Originally posted by @thomas-senechal in #1312 (comment)

@Thykof Thykof mentioned this issue Jan 8, 2024
10 tasks
@Thykof
Copy link
Contributor Author

Thykof commented Jan 9, 2024

related to #1320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant