Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color for semantic list urls/links too dark with Joplin dark themes #2

Open
djsudduth opened this issue Sep 9, 2022 · 4 comments
Open

Comments

@djsudduth
Copy link

djsudduth commented Sep 9, 2022

Hi, the CSS for the semantic list urls when Joplin is in dark mode is too dark to be usable - and it seems this plugin's iframe uses this CSS snippet to highlight links (which I assume is a default):

a:-webkit-any-link {
color: -webkit-link;
cursor: pointer;
text-decoration: underline;
}

I've tried altering the plugin CSS but it seems to dynamically pull down the CSS into the .config/.../tmp folder and overwrite my changes. Since this is an iframe - the userchrome.css doesn't affect it. Is there a way to change those dark blue links when using a dark theme??

Thanks!

@marcgreen
Copy link
Owner

Hey, thanks for the issue! I don't know how to fix this off-hand, but I can try looking into it.

Btw, how long have you been using the plugin? Have you found it helpful at all?

@djsudduth
Copy link
Author

Not sure yet. Only just started using it. But, I have a lot of notes now so I'm curious how effective it will be.

I can't figure out where your css file comes from. It dynamically overwrites the css in the tmp folder every time you launch Joplin.

@djsudduth
Copy link
Author

djsudduth commented Mar 31, 2023

I discovered where you would need to add the appropriate styling CSS for this plugin -> in src/index.ts
the CSS needs to be added here:
// Create the panel object
const panel = await joplin.views.panels.create('semanticlly_similar_notes_panel');
// Add the CSS file to the view, right after it has been created:
await joplin.views.panels.addScript(panel, './webview.css');

See this page: https://joplinapp.org/api/tutorials/toc_plugin/

@mshuflin
Copy link

mshuflin commented Jan 7, 2024

looks like this would be a really helpful plugin, thank you for developing. I am having the same issue, dark blue links when using a dark theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants