Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with Error Prone #6

Open
thehoneymad opened this issue Nov 7, 2022 · 0 comments
Open

Integrate with Error Prone #6

thehoneymad opened this issue Nov 7, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@thehoneymad
Copy link
Collaborator

Integrate build process with https://github.com/google/error-prone. The original library came with this to ensure static compilation checks. But I had to remove it in #4 because it was breaking builds due to Java version compatibility.
@thehoneymad thehoneymad added the good first issue Good for newcomers label Nov 7, 2022
thehoneymad pushed a commit that referenced this issue Nov 7, 2022
Removed "Error Prone" integration
8a658de 
I removed Google Error Prone integration for the time being.
This integration is outdated and is breaking builds due to Java
compatibility mismatch.

I created a new issue #6
to continue this particular effort there.

test: Gradle Build is still failing due to checkstyle.
@thehoneymad thehoneymad mentioned this issue Nov 9, 2022
Merged
birkskyum pushed a commit that referenced this issue Nov 15, 2022
@thehoneymad
#4 - Removal of Mapbox SDK except utility libraries (#8)
b326cfd 
* Removed mapbox specific cfn template

I removed mapbox specific cfn template that I assume does the following
- Manages permission to access to mapbox S3 buckets for production and staging
build artifacts.

Build: Gradle build is still failing. No build test was done.

* Removed "Error Prone" integration

I removed Google Error Prone integration for the time being.
This integration is outdated and is breaking builds due to Java
compatibility mismatch.

I created a new issue #6
to continue this particular effort there.

test: Gradle Build is still failing due to checkstyle.

* [#4] Building with gradle enabled

Finally maanged to build with gradle. Clearly the checkstyle rules
are not consistently propagated to all sub-projects. But that is not
what I am tackling right now.

I added separate checkstyle directive to sub projects. The checkstyle
fix will be done later in this work in progress.

test: ./gradlew build

* Removed Sample project

In this changeset I removed the sample project that demonsrated Mapbox's API samples.

* [#4] Removed optimization, matrix, matching, geocoding, directions, and cli

I removed optimization, matrix, matching, geocoding, directions, and cli
project in one go. These are Mapbox API wrappers that are not required for
MapLibre Android.

test: gradlew build

* Remove route-tiles and isochrones

* Removed tile-query, and speech

* [#4] Removed services-core and services-staticmap

Following the suite of removing Mapbox SDK from here. Removed services-core
and services-staticmap from here too. Ideally the only two projects that should
remain are
1. services-geojson
2. services-turf

None of these rely on a Mapbox API interface. Both of these are utility libraries.

build: ./gradlew build

* [#4] Removed services-core from repo

This repository is publishing every library under org.maplibre.gl namespace.
Every one of the package is named MapLibre Android SDK. I removed the core
services package finally since this is not required anymore.

test: gradlew build

* [#4] Turning off checkstyle to pass the build

* [#4] Cleaning up unnecessary dependencies

Cleaned up unnecessary dependencies. I removed sonatype and artifactory
publishing. I still intend to publish to maven but I do not think that
has anything to do with these. If required, I will bring them back.

test: ./gradlew clean build

* [#4] Build logic cleanup in progress

* [#4 #7] Upgraded Gradle version to 7.5.1

Upgraded gradle version to 7.5.1. I updated the deprecated archive
classifier properties. I also updated test depdencies to testImplementation
based on new documentation.

test: ./gradlew build

* [#4] Documentation update to reflect current status, more to follow

Co-authored-by: Swagata Prateek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
MapLibre Native Android
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehoneymad