Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features flicker on selection change #871

Open
NCorbeau opened this issue Feb 22, 2019 · 8 comments
Open

Features flicker on selection change #871

NCorbeau opened this issue Feb 22, 2019 · 8 comments
Labels
performance rendering Rendering issues and errors

Comments

@NCorbeau
Copy link

Hello,

When mapbox-gl-draw source is getting big, user can observe flickering of drawn features on selection change:

feb-22-2019 12-00-28

It seems like plugin moves features from one source to another and when there's many features on the map this operation takes time. Maybe for a moment features affected by selection change are not part of any source.

Do you think it is possible to somehow fix this?

Demo: https://jsfiddle.net/tpe907dc/
@vladimir-barsuchenko
Copy link

Facing the same issue

@ThiyagarajanShivSankaran
Copy link

ThiyagarajanShivSankaran commented Apr 2, 2019 •
edited
Loading

We are also facing the same. Please fix this.

@Danita
Copy link

Danita commented Apr 15, 2019

We're also experiencing this and it happens with just 2 features on the map. The switching between the hot and cold layers is very noticeable.

@Akiyamka
Copy link

Akiyamka commented Apr 17, 2019 •
edited
Loading

Any news here? Flikering starts at first mousemove after select/deselect video

@macobo
Copy link

macobo commented Sep 10, 2019

Similar problem in our application.

@macobo macobo mentioned this issue Sep 11, 2019
Open
@kkaefer kkaefer added performance rendering Rendering issues and errors labels Jan 7, 2020
@campusano13
Copy link

Same problem for us. Any update on this?

@agusterodin
Copy link

This is a borderline showstopper for switching from leaflet draw with leaflet-mapbox to straight mapbox on a personal project :(

@usb248 usb248 mentioned this issue May 6, 2020
Merged
vhautsal added a commit to VRTFinland/mapbox-gl-draw that referenced this issue Dec 2, 2020
@vhautsal
Eliminate switching between hot and cold sources
a9af298 
This switching causes severe flickering and there seems to be no
performance advantage at least in our use case.

See:

<mapbox#871>
<mapbox#916>
@vhautsal vhautsal mentioned this issue Dec 2, 2020
Open
@gushuro
Copy link

gushuro commented Mar 3, 2021

Is there any plan to review/merge #1026 anytime soon? Or any reason why you won't?
It fixes this issue for our project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance rendering Rendering issues and errors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@kkaefer @macobo @Danita @NCorbeau @gushuro @Akiyamka @vladimir-barsuchenko @agusterodin @ThiyagarajanShivSankaran @campusano13