Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the mantid workbench main settings window #38293

Open
jhaigh0 opened this issue Oct 24, 2024 · 0 comments
Open

Improve the mantid workbench main settings window #38293

jhaigh0 opened this issue Oct 24, 2024 · 0 comments
Assignees
Labels
GUI Issues and pull requests specific to the Mantid Workbench GUI. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone

Comments

@jhaigh0
Copy link
Contributor

jhaigh0 commented Oct 24, 2024

Currently, any changes you make in the settings widget immediately write to file with no way to undo.

The settings widget should be changed to have 'Apply', 'Ok', and 'Cancel' buttons like you'd typically find in an interface like this.

This might be best solved by switching to an MVP implementation where the model can hold the potential new state for the settings.

@jhaigh0 jhaigh0 added Maintenance Unassigned issues to be addressed in the next maintenance period. GUI Issues and pull requests specific to the Mantid Workbench GUI. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Oct 24, 2024
@jhaigh0 jhaigh0 added this to the Release 6.12 milestone Oct 24, 2024
@jhaigh0 jhaigh0 self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues and pull requests specific to the Mantid Workbench GUI. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: No status
Development

No branches or pull requests

1 participant