Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install MSlice via conda #38215

Open
SilkeSchomann opened this issue Oct 18, 2024 · 0 comments · May be fixed by #38299
Open

Install MSlice via conda #38215

SilkeSchomann opened this issue Oct 18, 2024 · 0 comments · May be fixed by #38299
Assignees
@SilkeSchomann
Labels
Direct Inelastic Issues and pull requests related to direct inelastic ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS
Milestone
Release 6.12

Comments

@SilkeSchomann
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At the moment MSlice is added to Mantid as an external project via cmake. This has caused problems in the past because of bugs in some cmake versions. It also means that MSlice is getting updated for every developer whenever the SHA changes, even when the developer is not using MSlice.

Describe the solution you'd like
Since MSlice is a standalone conda package, it could be an external interface that is only installed when required. This is done, for instance, for Shiver or SNAPRed.

Describe alternatives you've considered
When adding MSlice to the conda requirements for Mantid, there are problems with circular dependencies as the MSlice package depends on mantid and mantidqt conda packages. It also means it is installed for everyone and not just MSlice users.
@SilkeSchomann SilkeSchomann added Direct Inelastic Issues and pull requests related to direct inelastic ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS labels Oct 18, 2024
@SilkeSchomann SilkeSchomann added this to the Release 6.12 milestone Oct 18, 2024
@SilkeSchomann SilkeSchomann self-assigned this Oct 18, 2024
@SilkeSchomann SilkeSchomann linked a pull request Oct 25, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilkeSchomann SilkeSchomann

Labels
Direct Inelastic Issues and pull requests related to direct inelastic ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS
Projects
None yet
Milestone
Release 6.12
Development

Successfully merging a pull request may close this issue.

Use Mslice as conda package instead of an external interface mantidproject/mantid
1 participant
@SilkeSchomann