Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme and child theme upgrade #40

Open
thomas7467 opened this issue Dec 2, 2020 · 4 comments
Open

theme and child theme upgrade #40

thomas7467 opened this issue Dec 2, 2020 · 4 comments

Comments

@thomas7467
Copy link

Hi devTeam,

Just a stupid question : what is the way to upgrade the previous creativeshop version ie the child theme?

Just copy the src folder content in themes directories?

thks
Thomas

@Monoget
Copy link

Monoget commented Dec 27, 2020

Create your own theme folder in app/code directory with theme.xml and registration.php and inherit creativeshop as a parent theme.

@mborkowski
Copy link

For more details you can go to official documentation. Remember to never override anything directly in theme-creativeshop, if you do so you will either lose possibility of getting new versions or if you decide to update - you will lose all your changes

@fritzmg
Copy link
Contributor

fritzmg commented Jun 17, 2021

@Monoget @mborkowski that's not really what @thomas7467 is asking, as far as I understand it. The question is: if a new version of the package creativestyle/theme-creativeshop is released, what do you have to do to update your actual child theme? Do you e.g. simply run composer update to update the dependencies (and thus your own theme + creativestyle/theme-creativeshop) and then you run yarn build in your theme again? But wouldn't that override something?

@mborkowski
Copy link

The first thing is to run composer update. Next, you rebuild Creativeshop with yarn build. As every update, update of theme-creativeshop can also break something.

"But wouldn't that override something?" - no, if you avoid overrides of original theme-creativeshop package. All changes should be always done in your theme.

We follow semver rules to keep things clear. Every major update is by rule introducing some breaking changes and you have to re-test your theme and check diff of the release to make sure your project won't get into production with some bugs caused by customizations in your theme. Breaking change means that implementation of given component changed, and actual customization won't work anymore if any (customization) was made in affected area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants