No ability to NOT enable catalog integration by default

[ihor-sviziev]

When installing extension and configuring sync, the catalog sync is enabled by default, and even when you don't need it - it starts automatically pushing products to Meta.

It looks like it's caused by

meta-for-magento2/app/code/Meta/BusinessExtension/Controller/Adminhtml/Ajax/PersistConfiguration.php

Lines 158 to 169 in c100f2d

	public function enableCatalogSync($commercePartnerIntegrationId, $storeId)
	{
	if ($commercePartnerIntegrationId) {
	$this->fbeHelper->log(sprintf('Catalog sync is enabled for store %s', $storeId));
	$this->systemConfig->saveConfig(
	SystemConfig::XML_PATH_FACEBOOK_ENABLE_CATALOG_SYNC,
	true,
	$storeId
	);
	}
	return $this;

and

meta-for-magento2/app/code/Meta/Catalog/etc/events.xml

Lines 9 to 11 in a58e1d7

	<event name="facebook_fbe_onboarding_after">
	<observer name="facebook_sync_full_catalog" instance="Meta\Catalog\Observer\Facebook\SyncFullCatalog" />
	</event>

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

1. [Screenshots, logs or description]

Actual result (*)

1. [Screenshots, logs or description]

[ihor-sviziev]

Fixed by disabling the Meta_Catalog extension in the config.php file, but it's currently impossible to disable it through admin or at least through php bin/magento module:disable Meta_Catalog due to existing dependence from Meta_Sales exntesion.
So far, module is diabled and order sync still works fine

[zlik]

@singhramanpreett @cristiannancumeta

[zlik]

@ihor-sviziev, I believe in the latest version, we always want for products to be synced to Meta because it improves catalog quality and drives ads performance for the seller. If there's an existing feed coming from other sources than our extension, that shouldn't be a problem – we should be able to correctly resolve any product duplicates.

[ihor-sviziev]

@zlik, we don't want to fight with all the integration all at once (potential issues with different prices, different discounts, conflicts with already installed extensions, solving how to manage product descriptions for different languages, etc), so we would like to start with something simple. A simple thing is an XML feed, which we can generate as a static file and update regularly. This definitely won't generate any unexpected load on production, won't cause any exceptions, etc.
So, not having the ability to disable a catalog sync isn't a good thing.

[zlik]

@zlik, we don't want to fight with all the integration all at once (potential issues with different prices, different discounts, conflicts with already installed extensions, solving how to manage product descriptions for different languages, etc), so we would like to start with something simple. A simple thing is an XML feed, which we can generate as a static file and update regularly. This definitely won't generate any unexpected load on production, won't cause any exceptions, etc. So, not having the ability to disable a catalog sync isn't a good thing.

I see your point @ihor-sviziev, makes a lot of sense to me! I'm checking with the team if there's a better way to handle this. We could potentially ask during onboarding whether the seller wants to enable catalog sync or not. Please stay tuned, we should get back to you on this shortly!

[sol-loup]

@ihor-sviziev, this as well as your other issue should be resolvable through the configs we exposed