Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min height converter throw error when new style is added to mobile breakpoint #877

Open
syno-jde opened this issue Oct 24, 2024 · 1 comment

Comments

@syno-jde
Copy link

Hello!

I want to have the possibility to define specific margin and padding in desktop and mobile like min-height but it's throw an error in the back-office.

Step to reproduce

  1. Add mobile breakpoint to existing margins_and_padding field (Vendor/PageBuilder/view/adminhtml/ui_component/pagebuilder_base_form.xml):
<?xml version="1.0" encoding="UTF-8"?>
<form xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd">
    <fieldset name="advanced">
        <field name="margins_and_padding" formElement="input">
            <argument name="data" xsi:type="array">
                <item name="config" xsi:type="array">
                    <item name="default" xsi:type="null" />
                    <item name="breakpoints" xsi:type="array">
                        <item name="mobile" xsi:type="boolean">true</item>
                    </item>
                </item>
            </argument>
        </field>
    </fieldset>
</form>
  1. Add padding or margin in mobile view in Banner block form. Save. Error is throwed in the console.

I fixed it in my fork develop...syno-jde:magento2-page-builder:develop

Copy link

m2-assistant bot commented Oct 24, 2024

Hi @syno-jde. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant