Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Preview Images Incorrectly Saved to Media Directory #842

Open
bluemwhitew opened this issue Feb 1, 2023 · 4 comments
Open

Template Preview Images Incorrectly Saved to Media Directory #842

bluemwhitew opened this issue Feb 1, 2023 · 4 comments
Assignees
@bluemwhitew
Labels
bug Partner: Vaimo https://www.vaimo.com Progress: PR created

Comments

@bluemwhitew
Copy link
Contributor

bluemwhitew commented Feb 1, 2023 •
edited
Loading

Preconditions (*)

  1. Adobe Commerce 2.4.4 (or greater)
  2. Page Builder 2.2.2 (or greater)
  3. bin/magento config:set cms/pagebuilder/enabled 1

Steps to Reproduce (*)

  1. Click on any Page Builder-enabled field (doesn't have to be empty)
  2. Click Save as Template
  3. Define a Template Name ("Example" in my case)
  4. Click Save
  5. Verify that you see, "The current contents of Page Builder has been successfully saved as a template."
  6. Click Apply Template
  7. Inspect the Preview Image path (can be full-size or thumbnail) from the template you just saved

Expected Result (*)

  1. Image(s) are stored under ~/pub/media/.template-manager/

Actual Result (*)

  1. Image(s) are stored under ~/pub/media/ but contain .template-manager in the name, implying missing DS

Notes

Big thanks to @Karlasa and other @vaimo team members who quickly helped me to validate this on various platforms, configurations, etc. 🙏🏻
@bluemwhitew bluemwhitew added bug Partner: Vaimo https://www.vaimo.com labels Feb 1, 2023
@m2-assistant
Copy link

m2-assistant bot commented Feb 1, 2023

Hi @bluemwhitew. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this

@bluemwhitew
Copy link
Contributor Author

@magento I am working on this

bluemwhitew added a commit to bluemwhitew/magento2-page-builder that referenced this issue Feb 1, 2023
@bluemwhitew
magento#842: Template Preview Images Incorrectly Saved to Media Direc…
9fd0895 
…tory

- Adding `use function` for `preg_replace`, `str_replace`, `strpos`, `strtolower`, `substr`, and `uniqid`
- Adding Missing `DIRECTORY_SEPARATOR`
- Adding Missing `@throws`
- Fixing `@return` Type(s)
- Making `phpcs:ignore` Less Generic
@bluemwhitew bluemwhitew mentioned this issue Feb 1, 2023
Open
7 tasks
@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in Backlog Aug 14, 2024
@engcom-Hotel
Copy link
Collaborator

@adobe export issue to Jira project PB

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PB-1606 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluemwhitew bluemwhitew

Labels
bug Partner: Vaimo https://www.vaimo.com Progress: PR created
Projects
Backlog
Status: Pull Request In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bluemwhitew @engcom-Hotel @github-jira-sync-bot