Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set image size in carousel - through view.xml? #839

Open
IanFiretoys opened this issue Jan 9, 2023 · 1 comment
Open

set image size in carousel - through view.xml? #839

IanFiretoys opened this issue Jan 9, 2023 · 1 comment

Comments

@IanFiretoys
Copy link

Description (*)

currently, you can specify the breakpoints and number of images in a carousel in the view.xml of your theme, (by extending the vars from the module's view.xml)

however, setting these to any lower number isn't very useful, as it leaves a ton of blank space.

Expected behavior (*)

adding an <image id="pagebuilder_carousel_image"> option to the view.xml to set the carousel image sizes would resolve this, ideally along with some mods in the slick.js file to accomodate the new image size and adapt the containers accordingly

Benefits

would make the pagebuilder carousels much more versatile, allowing people to more easily dump bulky additional OWL carousel modules

Additional information

@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2023

Hi @IanFiretoys. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Grooming
Development

No branches or pull requests

1 participant