New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock cron jobs in-appropriate comments #791

Closed

manaftryzens opened this issue Dec 31, 2020 · 1 comment · May be fixed by #813

Labels

bug community Progress: done

manaftryzens commented Dec 31, 2020

Unlock cron job says it update the running jobs as missed
https://github.com/magento/ece-tools/blob/develop/src/Step/Deploy/UnlockCronJobs.php says it updates the cron jobs from running status to "missed" status. But it actually updates them as "error"

Modify the comments
Modify the comments at https://github.com/magento/ece-tools/blob/develop/src/Step/Deploy/UnlockCronJobs.php , as it should say ' Moves all cron jobs from status running to status "error" '.

m2-community-project bot added the Progress: ready for grooming label

YPyltiai added bug community labels

Contributor

andriyShevtsov commented May 31, 2022

Should be fixed now

andriyShevtsov closed this as completed

m2-community-project bot added Progress: done and removed Progress: ready for grooming labels

fredden mentioned this issue

Update comment to match code #813

Open

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment