Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current limitations for auto-generated pipelines for component #286

Open
Tomcli opened this issue Jan 14, 2022 · 2 comments
Open

Current limitations for auto-generated pipelines for component #286

Tomcli opened this issue Jan 14, 2022 · 2 comments

Comments

@Tomcli
Copy link
Member

Tomcli commented Jan 14, 2022

Is your feature request related to a problem? Please describe.
Here is the list of limitations for the current code generation:

  1. Description is required in MLX, but optional in KFP
  2. MLX only can pass parameters as string type. If KFP component has non-string type, the pipeline will have type errors in the arguments.
  3. Component parameter names need to be sanitized as Python variable. (https://github.com/kubeflow/pipelines/blob/master/components/git/clone/component.yaml)
  4. MLX converted double quote " into single quote ' for all the parameter values. This doesn't work for some components when users need to pass in JSON string with double quote around their keys and values. (e.g. https://github.com/kubeflow/pipelines/blob/master/components/contrib/json/Combine_lists/component.yaml)

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Tomcli
Copy link
Member Author

Tomcli commented Jan 14, 2022

I think 3 and 4 should be easier to fix. 1 and 2 is nice to have but could be difficult to cover all the edge cases.

@Tomcli
Copy link
Member Author

Tomcli commented Jan 14, 2022

/cc @ckadner

ckadner added a commit to ckadner/mlx that referenced this issue Jan 19, 2022
* Many kubeflow/pipelines components do not have a description
* Replace characters in component parameter names that are not
  allowed in Python identifiers

Related machine-learning-exchange#286

Signed-off-by: Christian Kadner <[email protected]>
mlx-bot pushed a commit that referenced this issue Jan 20, 2022
* Many kubeflow/pipelines components do not have a description
* Replace characters in component parameter names that are not
  allowed in Python identifiers

Related #286

Signed-off-by: Christian Kadner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant