Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses are needed #14

Open
raguay opened this issue Jun 29, 2023 · 4 comments
Open

Addresses are needed #14

raguay opened this issue Jun 29, 2023 · 4 comments

Comments

@raguay
Copy link

raguay commented Jun 29, 2023

For my invoices, I'm required to have the address for the organization paying under their name and my address under my companies name. You could use -toaddress and -fromaddress in order to match the other flags.

But, it might be better to have them in a database and pull it up that way. Then you don't have to have the full address on every command line. Add it once, parse it in, and store it by the name and reuse by the name later.

@ehrktia
Copy link

ehrktia commented Jul 1, 2023

@raguay #21
CC: @maaslalani

please review when you have few mins

@rouilj
Copy link

rouilj commented Jul 4, 2023

But, it might be better to have them in a database and pull it up that way. Then you don't have to have the full address on every command line. Add it once, parse it in, and store it by the name and reuse by the name later.

or just put to-address and from-address in a json or yaml file and use --import client_name.json once #24 is straightened out.

@raguay
Copy link
Author

raguay commented Jul 4, 2023

Yes, a JSON file would be better. It would then be easy to include address information from different countries (there are different formats). Also, doing batch jobs would be easy if it was in a JSON file already.

@wpinfusion
Copy link

I would like to suggest 1 json file that would hold all clients:

{
  "axelfoley": {
    "First Name": "Axel",
    "Last Name": "Foley",
    "Address": "Street 123",
    "Zip": "90210",
    "City": "Beverly Hills",
    "State": "California",
    "Country": "USA"
  },
  "johndoe": {
    "First Name": "John",
    "Last Name": "Doe",
    "Address": "Avenue 123",
    "Zip": "90210",
    "City": "Beverly Hills",
    "State": "California",
    "Country": "USA"
  }
}

And have users just issue invoice generate --client axelfoley
In fact, we could add the 'From' entities in the same file, and the misc settings too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants