Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add requirement for issuerFirm to be registered to allow use of setKYCApproval() #29

Open
Ryanmtate opened this issue Jul 23, 2018 · 0 comments
Assignees
Labels
RFC Request For Comments

Comments

@Ryanmtate
Copy link
Contributor

Problem:
There is currently no check if an issuerFirm is registered to be able to use the setKYCApproval method.

Adding this check would require an initial firm to be registered to allow addition of following firms.

At a low-level, a firm can be registered directly with the Storage contract by an owner of the storage contract.

Solutions:

  • Add a modifier to check registration for issuerFirm
  • Add constructor logic;
  • Handle this at the tsm API level;

Possible solution is to add a method in the constructor of the TokenIOAuthority contract to set the default issuerFirm (i.e. Token, Inc.)

Code:

https://github.com/tokenio/tokeninc-smart-contracts/blob/45eff8892efb222ba9b21af099f09fea32e044b0/contracts/TokenIOLib.sol#L227


As a reminder, issuerFirm is synonymous with a "provider". Providers are allowed to hold custodian funds and issue/destroy tokens at time of deposit/withdraw.

@Ryanmtate Ryanmtate added the RFC Request For Comments label Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments
Projects
None yet
Development

No branches or pull requests

2 participants