Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple less "concrete" suggestions #32

Open
helixbass opened this issue Mar 19, 2023 · 0 comments
Open

A couple less "concrete" suggestions #32

helixbass opened this issue Mar 19, 2023 · 0 comments
Labels

Comments

@helixbass
Copy link

The content that the question is about

No response

The question

Here are a couple of other notes that I took while going through the book that are more general feedback/suggestions about particular sections (vs typos etc):

  • Chapter 3 - the explanation of fences feels like it could have been fleshed out a bit more, I came away slightly confused as to what exactly it guarantees and why/how
  • Chapter 5: I could use a bit more of an explanation of the stuff around Channel<T> being Sync if T: Send (I've read about Send/Sync but feel a bit fuzzy on those generally) eg why exactly is it ok to implement Sync under those conditions and how exactly does that flow through the code to give us the desired/expected use of the channel across threads?

(no need to try and explain these here unless you feel very compelled to, more just suggestions for those sections of the book)

I found the book to be written at a very high level of quality throughout, I appreciated how "focused" and "sober" it was, so thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant