Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URL generation with offline pages in path #7

Open
luya-bot opened this issue Dec 18, 2017 · 4 comments
Open

Invalid URL generation with offline pages in path #7

luya-bot opened this issue Dec 18, 2017 · 4 comments
Labels

Comments

@luya-bot
Copy link

This issue has originally been reported by @rolandschaub at luyadev/luya#1382.
Moved here by @nadar.


What steps will reproduce the problem?

Make a web page with children offline. URLs to the child pages won't be formed correctly – LUYA will omit all path segments except the one for the target page. Example:

www.testsite.com/abc/def/ghj
will turn to the following when the page with the path segment "def" is offline:
www.testsite.com/ghj

What is the expected result?

The URL should include all path segments, including the ones of offline pages:
www.testsite.com/abc/def/ghj

Of course, the URL www.testsite.com/abc/def/ should still throw a 404 error, but www.testsite.com/abc/def/ghj should work and be generated correctly.

@nadar
Copy link
Member

nadar commented Feb 27, 2019

This is only possible when we add offline pages to the menu component.

@rolandschaub
Copy link
Member

If this is not possible then all children pages of offline pages should be treated as offline, too. The system should not generate invalid URLs.

@nadar
Copy link
Member

nadar commented Feb 27, 2019

I think we could integrate the offline pages for building the menu path /foo/bar/xyz and remove them afterwards. I will try, this could work. Not sure how the path is resolved afterwards, but i will test.

@rolandschaub
Copy link
Member

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants