Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: drop or improve pl.url #420

Open
Tieske opened this issue Feb 13, 2022 · 4 comments
Open

Cleanup: drop or improve pl.url #420

Tieske opened this issue Feb 13, 2022 · 4 comments

Comments

@Tieske
Copy link
Member

Tieske commented Feb 13, 2022

This module currently has extremely minimalistic features. Either is hsould be deprecated in favor of specialized libraries, or alternatively (since urls are very commonly used in many applications today) it should be updated to get a more feature rich implementation

@alerque
Copy link
Member

alerque commented Feb 15, 2022

Related, from the author of curl: https://daniel.haxx.se/blog/2022/01/10/dont-mix-url-parsers/

@Tieske
Copy link
Member Author

Tieske commented Feb 16, 2022

That sounds like you're in favor of dropping the module @alerque ?

@alerque
Copy link
Member

alerque commented Feb 16, 2022

Ha, maybe. I guess it depends a little bit on what the alternatives are. One reason I was strongly in favor of dropping the XML module is there were so much better options available in the Lua ecosystem, hence I didn't think it was worth any effort to fix or develop. If there are not solid upgrades for anybody that might be using pl.url module now I would not want to see it dropped until there was something at least as good or better that was easy to migrate too and proven to be robust across different platforms.

I guess the point of dropping that link was just to point out that in spite of being a "small" feature it is not that easy to get right. That goes for whether we work on improving the module or supporting an alternative.

Do we have any internal dependencies on pl.url?

@Tieske
Copy link
Member Author

Tieske commented Feb 16, 2022

a quick search did not show any dependencies. I was thinking of maybe copying an existing implementation and enable it for more flexible use, like luasocket one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants