Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing turbolinks with hotwire #629

Open
matthewmcgarvey opened this issue Apr 16, 2021 · 4 comments
Open

Consider replacing turbolinks with hotwire #629

matthewmcgarvey opened this issue Apr 16, 2021 · 4 comments

Comments

@matthewmcgarvey
Copy link
Member

I'm not sure if we want to add all of hotwire or just turbo since that has turbolinks in it.

@stephendolan
Copy link
Member

stephendolan commented Apr 17, 2021

I'm going to give https://github.com/jgaskins/turbo a try in my latest app, which will tangentially give me some experience with the JS portion as well.

One important thing to note is that we'll lose our disable_with helpers if we make this move and also elect to remove rails_ujs, which is recommended by the Turbo team in the Rails world. Not sure if we'd need to do that in Lucky as well, but worth considering!

@snadon
Copy link
Contributor

snadon commented May 4, 2021

I'm replacing turbolinks with turbo right now. AFAIK, rails_ujs still works as long as you remove all your data-remote.

You'll need to add data_turbo: false to your forms otherwise you'll get an error because turbo expects a 400 or a redirect and not a 200. Currently we cannot use another status code when rendering a page (luckyframework/lucky#1312).

@rmarronnier
Copy link

I'm bumping this since luckyframework/lucky#1312 is fixed and hotwire/turbo has matured a lot since.

@stephendolan
Copy link
Member

We actually already have a discussion relating to this here:
luckyframework/lucky#1600

The next step for anyone who would like to see this is to take a stab at a PR so that the core team can review what would actually need to change in the scaffolded app to get a functional Lucky app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants