New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug in the implementation of the top-p sampling #60

Open

allblueJT opened this issue Sep 27, 2024 · 0 comments

allblueJT commented Sep 27, 2024

PaLM-rlhf-pytorch/palm_rlhf_pytorch/utils.py

Line 60 in 6b02ee3

return sorted_logits.scatter(1, sorted_indices, sorted_logits)

Using the sorted indices to index the sorted indices does not make sense.
I think it may be
return logits.scatter(1, sorted_indices, sorted_logits)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment