Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presubmit linting not picking up whitespace problems #257

Open
mithro opened this issue Jun 18, 2016 · 1 comment
Open

presubmit linting not picking up whitespace problems #257

mithro opened this issue Jun 18, 2016 · 1 comment

Comments

@mithro
Copy link
Contributor

mithro commented Jun 18, 2016

It appears that the pylint checking isn't configured correctly because it isn't warning about a bunch of formatting problems. I discovered the following;

This should fail with requiring 4 spaces;

abc(
  "hello")

This should fail with requiring 2 newlines between classes;

class ABC(object):
  pass

class BCD(object):
  pass
@maruel
Copy link
Member

maruel commented Jun 21, 2016

It's a problem in depot_tools. We should file and fix there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants
@mithro @maruel and others