Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on macOS #182

Open
dishti opened this issue Dec 7, 2021 · 6 comments
Open

Tests failing on macOS #182

dishti opened this issue Dec 7, 2021 · 6 comments

Comments

@dishti
Copy link

dishti commented Dec 7, 2021

Hi!
I'm trying to run Lucene++ on macOS Catalina. A large number of tests seem to be failing on mac (>100).
Screenshot 2021-12-07 at 2 45 08 AM

Some of them appear to be due to refCount issues:
Screenshot 2021-12-07 at 1 54 58 PM

And few of them due to exceptions not being caught correctly. Are there any other settings that need to be set to be able to run the tests successfully on mac?

@kmatheussen
Copy link
Contributor

I've actually forgot to run the tests. But now I did, and there's a lot of tsan hits, even after I fixed most (perhaps all) race conditions in conjunction with initialization of static variables (see #181).

@dishti
Copy link
Author

dishti commented Dec 8, 2021

Are these tsan hits different from the ones that you've submitted fixes for?

@kmatheussen
Copy link
Contributor

I'm not sure. Some tsan hits might have been fixed by #183, but not all. All of the hits provided in #184 are run with the fixes in #183, so they are separate problems.

@kmatheussen
Copy link
Contributor

But you might want to apply the patch in #183. Maybe that's enough to pass the tests, I don't know.

@dishti
Copy link
Author

dishti commented Dec 8, 2021

This patch doesn't seem to fix the test failures

@barracuda156
Copy link
Contributor

3.0.8 passes all tests on 10.6 PowerPC. But fails to build on 14.2, ironically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants