Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending blank lines from the MDI (Terminal). #364

Closed
terjeio opened this issue Aug 16, 2023 · 12 comments
Closed

Allow sending blank lines from the MDI (Terminal). #364

terjeio opened this issue Aug 16, 2023 · 12 comments

Comments

@terjeio
Copy link

terjeio commented Aug 16, 2023

Is your feature request related to a problem? Please describe.
grblHAL repeats the last error until cleared by a blank line or a $-command for safety reasons. The v3 WebUI does not allow sending blank lines from the MDI.

Describe the solution you'd like
Allow sending blank lines.

Describe alternatives you've considered
Setting grblHAL compatibility level > 0 disables this safety feature alongside some other new features supported by the WebUI - tool changes is at least one prominent one. IMO not a good solution.

Additional context
See this OpenBuilds comment onwards.

@luc-github
Copy link
Owner

luc-github commented Aug 16, 2023

what is a blank line ?
\n ?
"" ?
0x0 ?

because webui send :
http://192.168.2.186/command?cmd=(command)
I am not sure sending http://192.168.2.186/command?cmd= will work
does: http://192.168.2.186/command?cmd=%C2%00 would do the trick ?

Let me know what should work and I wil add it - I also can add a variable if necessary to replace any not printable char

@terjeio
Copy link
Author

terjeio commented Aug 16, 2023

http://192.168.2.186/command?cmd= works after I modified my backend to test for blank lines. I just forward a newline to the command parser when received.

@terjeio
Copy link
Author

terjeio commented Aug 16, 2023

http://192.168.2.186/command?cmd=%C2%00 would do the trick ?

Not without further code changes to the backend. I prefer http://192.168.2.186/command?cmd=

@luc-github
Copy link
Owner

luc-github commented Aug 16, 2023

I have modified the webui to allow nothing as test but I forgot it add automaticaly a timestamp to bypass the cache :
http://192.168.2.186/command?cmd=&t=1692164825367 does this still work on your backend ?

@terjeio
Copy link
Author

terjeio commented Aug 16, 2023

Timestamp is ok and I guess needed when there is a proxy in between.

@luc-github
Copy link
Owner

Can you give a try to :
index.html.gz

@terjeio
Copy link
Author

terjeio commented Aug 16, 2023

Works! Thanks for quick implementation.

@luc-github
Copy link
Owner

Ok I will push it - I have just changed one thing compare to the version you test : emptyline won't go to history of command because it is not easy to see what command is that

@luc-github
Copy link
Owner

Implemented in version 39 d723801

@luc-github
Copy link
Owner

@terjeio you are welcome , it was an easy fix and happy it is useful ^_^

@terjeio
Copy link
Author

terjeio commented Aug 16, 2023

Again thanks, I'll report the fix in the OpenBuilds thread when I have pushed the change on my end.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants