From 8e0a22c842cfa7cdddbafe11de51dbd0f5b10073 Mon Sep 17 00:00:00 2001
From: Alex Soto <asotobu@gmail.com>
Date: Tue, 2 Oct 2018 17:16:40 +0200
Subject: [PATCH] feat(#1382): Rename filenames to filenameTypes

---
 .../maven/core/config/MappingConfig.java      | 20 +++++++++++--------
 doc/src/main/asciidoc/inc/_appendix.adoc      |  2 +-
 it/src/it/custom-raw-resources/pom.xml        |  2 +-
 .../maven/plugin/mojo/build/ResourceMojo.java |  4 +++-
 4 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/core/src/main/java/io/fabric8/maven/core/config/MappingConfig.java b/core/src/main/java/io/fabric8/maven/core/config/MappingConfig.java
index c0f109a80b..b07ada1349 100644
--- a/core/src/main/java/io/fabric8/maven/core/config/MappingConfig.java
+++ b/core/src/main/java/io/fabric8/maven/core/config/MappingConfig.java
@@ -1,24 +1,28 @@
 package io.fabric8.maven.core.config;
 
-import org.apache.maven.plugins.annotations.Parameter;
-
 public class MappingConfig {
 
-    @Parameter(required = true)
     private String kind;
 
-    @Parameter(required = true)
-    private String filenames;
+    private String filenameTypes;
 
     public String getKind() {
         return kind;
     }
 
-    public String getFilenames() {
-        return filenames;
+    public String getFilenameTypes() {
+        return filenameTypes;
     }
 
     public String[] getFilenamesAsArray() {
-        return filenames.split(",\\s*");
+        if (this.filenameTypes == null) {
+            return new String[0];
+        }
+        return filenameTypes.split(",\\s*");
+    }
+
+    public boolean isValid() {
+        return kind != null &&  filenameTypes.length() > 0;
     }
+
 }
diff --git a/doc/src/main/asciidoc/inc/_appendix.adoc b/doc/src/main/asciidoc/inc/_appendix.adoc
index 11e75f19ad..3971cc309b 100644
--- a/doc/src/main/asciidoc/inc/_appendix.adoc
+++ b/doc/src/main/asciidoc/inc/_appendix.adoc
@@ -25,7 +25,7 @@ By default if no environment variable nor system property is set, scan for a fil
     <mappings>
       <mapping>
         <kind>Var</kind>
-        <filenames>foo, bar</filenames>
+        <filenameTypes>foo, bar</filenameTypes>
       </mapping>
     </mappings>
   </configuration>
diff --git a/it/src/it/custom-raw-resources/pom.xml b/it/src/it/custom-raw-resources/pom.xml
index 47f574f84d..17e105cfac 100644
--- a/it/src/it/custom-raw-resources/pom.xml
+++ b/it/src/it/custom-raw-resources/pom.xml
@@ -34,7 +34,7 @@
           <mappings>
             <mapping>
               <kind>Service</kind>
-              <filenames>foo</filenames>
+              <filenameTypes>foo</filenameTypes>
             </mapping>
           </mappings>
         </configuration>
diff --git a/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java b/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java
index f7f9c11122..5dba72767d 100644
--- a/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java
+++ b/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java
@@ -431,7 +431,9 @@ private void updateKindFilenameMappings() {
         if (mappings != null) {
             final Map<String, List<String>> mappingKindFilename = new HashMap<>();
             for(MappingConfig mappingConfig : this.mappings) {
-                mappingKindFilename.put(mappingConfig.getKind(), Arrays.asList(mappingConfig.getFilenamesAsArray()));
+                if (mappingConfig.isValid()) {
+                    mappingKindFilename.put(mappingConfig.getKind(), Arrays.asList(mappingConfig.getFilenamesAsArray()));
+                }
             }
             KubernetesResourceUtil.updateKindFilenameMapper(mappingKindFilename);
         }