Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schema registry proxy handling #170

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jun 6, 2024

change schema_registry_proxy setting from uri to string to move URI validation further down so that "" is an acceptable value. accepting "" is useful when doing something like:

  schema_registry_proxy => "%{SCHEMA_REGISTRY_PROXY}"

But depending on environment that env var may be empty. This removes the need for templating.

To support this we need to validate the URI a bit later.

Also this PR removes uri handling of https and basic auth for the proxy url given that the schema registry itself doesn't support it either (see confluentinc/schema-registry#2137)

fixes #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"schema_registry_proxy" option does not work
2 participants