Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace actions broken #783

Open
okmiim opened this issue Dec 10, 2023 · 0 comments
Open

Workspace actions broken #783

okmiim opened this issue Dec 10, 2023 · 0 comments

Comments

@okmiim
Copy link
Collaborator

okmiim commented Dec 10, 2023

The workspace implementation of calendarize is (partly) broken. The index generation itself works fine, but actions like publish and discard are not properly handled anymore. Some indices are not properly cleaned up anymore etc., specifics need to be investigated.

Scenarios to be tested:

  • Create new event in workspace 'version' => ['action' => 'new']
  • Edit live record in workspace
    • a: Only edit the event record
    • b: Edit the configuration record
  • Publish workspace
    • 'version' =>['action' => 'publish', 'swapWith' => xyz,]
    • a: With existing live record
    • b: With workspace only record
  • Discard workspace version 'version' => ['action' => 'clearWSID']
    • a: Event + Configuration
    • b: only Configuration
  • Delete event in workspace

I highly suggest creation functional tests triggering the DataHandler with cmd- and datamaps (see here). It makes sense to "capture" these from real request as use them for test cases.

Where to start:

Another point to improve:
Overwriting the class WorkspaceRemoteServer is quite an intrusive way. It only hides the indices from being displayed in the BE module. Maybe this could be replaced by AfterCompiledCacheableDataForWorkspaceEvent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant