-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ics import: respect recurrence id #774
Comments
Hi @ftrojahn, one big painpoint with the ICS import is that is is only an "import" (add + update) and not really a "synchronization" (... + delete). I been thinking/planning (for a long time) to do a new implementation of the ICS handling, but did not get around to that. The modification of specific instance of a recurring series in iCalendar is actually reflected by the You could handle the import of specific recurring instances as follows:
A hacky way to get rid of non-existing ics-events:
Regards |
Hello,
we maintain an instance with more than 500 domains. So, there are a lot of ics imports (see verdigado/calendarize_external).
During integration of calendarize we noticed
otherwise, ics imports using the same source link "steal" events from each other
SEQUENCE
key in ics files is not respected.This leads to recurring events, which will be created (or old ones overwritten): but without the frequency ...
resulting in missing events.
Only workaround for now is, in the source ics calendar:
deleting the recurring event (which had a calendar exception) and recreating the recurring event from scratch,
which is not always possible (not all users own that calendar they export from).
I debugged it like this:
UID
and different
SEQUENCE
like 0 and 1.SEQUENCE:0
has theRRULE
=> frequency is set for the importid.SEQUENCE:1
has noRRULE
, but same UID => frequency is unset.Invalid frequency="{frequency}" in RRULE
errorsSEQUENCE:11
, but no other event with the sameUID
/ importIdIMHO we could fix this by attaching the sequence id to the importid like here:
master...verdigado:calendarize:add-sequenceid-to-importid
(no PR, just asking)
But this creates two other problems:
will be reimported using importId+sequenceid
That is due to: old imported events will not be deleted on ics import, if deleted in ics source. See #620 too.
So we would have to deal with finding all "old" importId events which must be deleted, if we have a new import with importId+sequenceid. ATM I see at least no slot/eventlistener where I can hook in to do this.
My test calendar link contains both of the above mentioned recurring events.
Any idea?
Thanx anyway for this great extension!
Falko
The text was updated successfully, but these errors were encountered: