Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Period.sorting_options not working as expected #518

Open
EsGeh opened this issue Sep 13, 2021 · 0 comments
Open

Period.sorting_options not working as expected #518

EsGeh opened this issue Sep 13, 2021 · 0 comments

Comments

@EsGeh
Copy link
Contributor

EsGeh commented Sep 13, 2021

Sorting Occurrences in combination with caching of Occurrences leads to buggy behaviour.
The sorting_options constructor argument for Period doesn't work as expected i.e. Occurrences in most cases are not sorted corresponding to the sorting_options given.
Reviewing the code I figured this is probably due to a bug excluding cached Occurrences from being sorted.

I created a pull request which aims at fixing this bug:
#516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant