Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip TLS always returns 1 #782

Open
PedroBuffon opened this issue Oct 1, 2024 · 2 comments
Open

Skip TLS always returns 1 #782

PedroBuffon opened this issue Oct 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@PedroBuffon
Copy link
Contributor

PedroBuffon commented Oct 1, 2024

So when coding the skip tls certificates for the Pi-Hole enhancement i notice that the toggle for the skip tls always returns a 1 no matter if the toggle is on or off, is this supposed to happen? im trying to figure out what causes it, it shouldnt do that.
If that is what is suppose to happen then all other apps that have the toggle no matter if it`s on or off will turn skip tls on and not verify certificates if needed.

I`m doing the skip tls button for nextcloud for the issue #770, using debugbar on the getConfigValue with Debugbar::info($this->config); for the toggle it gives out:

{#1883 ▼
+"url": "Redacted"
+"type": "f2baa52d02ca888455ce47823f47bf372d5eecb3"
+"username": "Redacted"
+"password": "Redacted"
+"ignore_tls": "1"
+"id": "4"
}

@PedroBuffon PedroBuffon added the bug Something isn't working label Oct 1, 2024
@PedroBuffon
Copy link
Contributor Author

PedroBuffon commented Oct 2, 2024

The PHP code in config.blade.php only updates the variable ignore_tls when the blade is reloaded, can have a workaround switching from Form::hidden to Form::select, but deleting the slider in the process and switching for a dropdown.

@mvdkleijn
Copy link
Collaborator

That makes sense. Form values are set when the form is initially loaded and only updated when when the form is submitted. If the test button is not doing an actual submit (didn't check), then the form value would not be updated.

BTW: just to clarify my level of involvement for you and others reading this... I stepped in as maintainer purely in order to look over PRs and merge them when ready so the community wouldn't get stuck. I don't have the time to actually work on code as my time is taken up by other projects, I'll leave that to the community. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Non-Docker Issues
Development

No branches or pull requests

2 participants