Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numlock state always remembered when changed #328

Open
RaychoRaykov opened this issue Mar 7, 2021 · 1 comment
Open

numlock state always remembered when changed #328

RaychoRaykov opened this issue Mar 7, 2021 · 1 comment

Comments

@RaychoRaykov
Copy link

RaychoRaykov commented Mar 7, 2021

 * csd version: 4.8.4+ulyssa
 * Distribution: Linux Mint 20.1
 * 64 bit

Issue

CSD writes to disk on every press of NumLock.

Steps to reproduce

Press the NumLock and watch the disk operation indicator.

Use sudo inotifywait -m -e modify -r /home/user/.config/dconf to watch the realtime modifications:

/home/user/.config/dconf/ MODIFY user.FRBRZ0
/home/user/.config/dconf/ MODIFY user.FRBRZ0

Expected behaviour

There is an option in dconf: '/org/cinnamon/settings-daemon/peripherals/keyboard/remember-numlock-state', which should be checked before writing to dconf. I can't see any change of CSD behaviour when this option is enabled or disabled.

The actual code from the source file csd-keyboard-manager.c Line: 162 is:

	if (numlock_state != manager->priv->old_state) {
		g_settings_set_enum (manager->priv->settings,
				     KEY_NUMLOCK_STATE,
				     numlock_state);
		manager->priv->old_state = numlock_state;
	}

Other information

The same behavior can be seen on previous versions of Linux Mint / Cinnamon.

@RaychoRaykov
Copy link
Author

I solved my problem by commenting out lines from 155 to 168 and recompiling the package. I don't want to remember the NumLock state between sessions at all, so it works for me. But it's a workaround losing feature to remember the state if someone needs it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant