Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean LinboxError/LinBoxError #187

Open
Breush opened this issue Mar 4, 2019 · 1 comment · May be fixed by #208
Open

Clean LinboxError/LinBoxError #187

Breush opened this issue Mar 4, 2019 · 1 comment · May be fixed by #208
Assignees
@Breush
Labels
enhancement

Comments

@Breush
Copy link
Contributor

Breush commented Mar 4, 2019

Two different general errors exist within linbox and they are both used:

  • linbox/util/debug.h: class LinBoxError (which inherits from NotImplementedYet)
  • linbox/util/error.h: class LinboxError (declined to things like LinboxMathInconsistentSystem)

Which one to keep?

About errors' use cases, it looks like we need:

  • LinBoxError (or some generic error)
  • PreconditionFailed
  • NotImplementedYet
  • InvalidInput (for readers)
  • InconsistentSystem
    but others are left unused (LinboxMathDivZero, LinBoxFailure, ...)

Moreover, while cleaning, in debug.h it looks like there is a concept of Exception (BadInputException, LINBOX_RAISE_EXCEPTION etc.) that is never used.
@ClementPernet
Copy link
Member

SolveFailed should also be considered when addressing this issue

@Breush Breush self-assigned this May 2, 2019
@Breush Breush linked a pull request May 3, 2019 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Breush Breush

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Base for error/debug/contracts cleanup linbox-team/linbox
3 participants
@Breush @jgdumas @ClementPernet