Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multitenant] S3 multitenancy: bucket implementation #5273

Open
Arsnael opened this issue Sep 18, 2024 · 5 comments
Open

[Multitenant] S3 multitenancy: bucket implementation #5273

Arsnael opened this issue Sep 18, 2024 · 5 comments

Comments

@Arsnael
Copy link
Member

Arsnael commented Sep 18, 2024

Implement the bucket implementation for S3 blobstore multitenancy.

Derive a bucketname per tenant within S3BlobStoreDAO when using the bucket mode.

DoD: Integration tests

@vttranlina
Copy link
Member

like what PG does

Can you help me give where code logic?
I checked the PGBlobStoreDAO, but don't see, even the pg table does not have a "domain" column,
I miss somewhere?

@Arsnael
Copy link
Member Author

Arsnael commented Sep 19, 2024

Can you help me give where code logic?

I asked myself the same question, as you can see in that other task => #5271 (comment)

So I aint sure either

@quantranhong1999
Copy link
Member

Q: Theoretically we already support 1 bucket per domain, no?

@Arsnael
Copy link
Member Author

Arsnael commented Sep 20, 2024

I fail to see where in the code though, we have a bucket name column but I feel it's always default somehow. RLS is disabled on that table as well. But i might be wrong, in which case please point me to the right piece of code

@quantranhong1999
Copy link
Member

I asked for S3 implementation instead.

@Arsnael Arsnael removed the grooming label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants