Skip to content
This repository has been archived by the owner on Jun 16, 2019. It is now read-only.

Refactor fcd's call convention detection #12

Open
surovic opened this issue Mar 1, 2018 · 1 comment
Open

Refactor fcd's call convention detection #12

surovic opened this issue Mar 1, 2018 · 1 comment
Assignees

Comments

@surovic
Copy link

surovic commented Mar 1, 2018

Fcd currently uses a lot of dirty hacks in it's call convention detection IR passes and classes. Notable examples include wrapping an Executable class object in an LLVM ImmutablePass and having ParameterRegistryPass be dependent on it for target information. This shouldn't really be necessary or desirable. Also generally there seems to be a lot of unused and possibly obsoleted code.

@surovic surovic self-assigned this Mar 1, 2018
@surovic
Copy link
Author

surovic commented Mar 12, 2018

Turned out that it was just easier to reimplement this using remill's functionality. So far the calling convention used is given by the target architecture and OS, with no option to change this. Fcd's --cc flag should be reenabled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant