Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication of vote items descriptions #96

Open
arwer13 opened this issue Nov 15, 2022 · 0 comments
Open

Remove duplication of vote items descriptions #96

arwer13 opened this issue Nov 15, 2022 · 0 comments

Comments

@arwer13
Copy link
Contributor

arwer13 commented Nov 15, 2022

There are two vote item descriptions:

1:
reference="Initial DAI funding Pool Maintenance Labs Ltd. within Nov'22-Apr'23 budget",
which goes into Aragon Finance NewTransaction event

2:

    vote_desc_items = [
        "1) Send DAI 1,500,000 to Pool Maintenance Labs Ltd. 0x17F6b2C738a63a8D3A113a228cfd0b373244633D",

which goes to Votings bot notifier

And usually the first description is more about "why and what in broader sense" and the second in more about the specific on-chain actions.

Maybe we should use uniform description, just exclude info about the addresses and values from NewTransaction event

And the question is in what form the unified description should be.

@arwer13 arwer13 changed the title Maybe remove duplication of descriptions Maybe remove duplication of vote items descriptions Nov 15, 2022
@arwer13 arwer13 changed the title Maybe remove duplication of vote items descriptions Remove duplication of vote items descriptions Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant