Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings #671

Open
Sod-Almighty opened this issue Mar 24, 2024 · 3 comments
Open

Warnings #671

Sod-Almighty opened this issue Mar 24, 2024 · 3 comments
Labels
hidraw Related to Linux/hidraw backend

Comments

@Sod-Almighty
Copy link

Warnings are errors, people!

linux/hidapi/hid.c:23: warning: "_GNU_SOURCE" redefined
   23 | #define _GNU_SOURCE /* needed for wcsdup() before glibc 2.10 */
      |
<command-line>: note: this is the location of the previous definition
linux/hidapi/hid.c: In function ‘void read_callback(libusb_transfer*)’:
linux/hidapi/hid.c:953:37: error: invalid conversion from ‘void*’ to ‘hid_device*’ {aka ‘hid_device_*’} [-fpermissive]
  953 |         hid_device *dev = transfer->user_data;
      |                           ~~~~~~~~~~^~~~~~~~~
      |                                     |
      |                                     void*
linux/hidapi/hid.c: In function ‘void* read_thread(void*)’:
linux/hidapi/hid.c:1022:27: error: invalid conversion from ‘void*’ to ‘hid_device*’ {aka ‘hid_device_*’} [-fpermissive]
 1022 |         hid_device *dev = param;
      |                           ^~~~~
      |                           |
      |                           void*
linux/hidapi/hid.c: In function ‘void cleanup_mutex(void*)’:
linux/hidapi/hid.c:1480:27: error: invalid conversion from ‘void*’ to ‘hid_device*’ {aka ‘hid_device_*’} [-fpermissive]
 1480 |         hid_device *dev = param;
      |                           ^~~~~
      |                           |
      |                           void*
@Youw
Copy link
Member

Youw commented Mar 25, 2024

PRs with fixes are welcome.

@Sod-Almighty
Copy link
Author

And that mentality is exactly what is wrong with open source. Take no responsibility for the quality of your work, and when someone reports a problem, tell them to feel free to fix it.

When someone reports a problem with my software, I fix it. Because I have pride in my work.

@Youw
Copy link
Member

Youw commented Mar 25, 2024

Because I have pride in my work.

And complete disrespect of other people's time and efforts.


I really appreciate reporting the problem - clearly our CI needs some improvements, I expected it should have caught it.

When someone reports a problem with my software

In order to support 10% of software I wrote at some point, I had to hire a team of 6 people.
If you're claiming you can support and fix all of the software you've ever written - it is either not much, or not much people is using it.

@mcuee mcuee added the hidraw Related to Linux/hidraw backend label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hidraw Related to Linux/hidraw backend
Projects
None yet
Development

No branches or pull requests

3 participants