Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Chunks with BytesMut #174

Open
thomaseizinger opened this issue Oct 9, 2023 · 2 comments
Open

refactor: replace Chunks with BytesMut #174

thomaseizinger opened this issue Oct 9, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@thomaseizinger
Copy link
Contributor

The entire Chunks module looks similar to what Bytes and BytesMut do so we can probably throw that away and use the bytes crate instead.

Is likely more efficient although that is not my main concern. We just want to maintain as little code as possible.

@thomaseizinger thomaseizinger added the help wanted Extra attention is needed label Oct 9, 2023
@mxinden
Copy link
Member

mxinden commented Nov 23, 2023

Note that we went the opposite way in the past: #77

(Not opposing the idea proposed here. Might help us to make a more informed decision.)

@thomaseizinger
Copy link
Contributor Author

Interesting, I'll have to dig into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants