Added manager node monitor #827
Open
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, our script that's designed to clean up after the project node port doesn't seem to work correctly. Because of this, it makes sense to monitor the manager node for the project node and to shut down when the manager node dies.
scohen
force-pushed
the
manager-node-monitoring
branch
from
5520a84
to
2b7c1e6
Compare
zachallaun
reviewed
Sep 6, 2024
There was a problem hiding this comment.
I've been thinking about this a bit and while it works, I was wondering if there was a lighter-weight solution.
Right now, when we start the remote node, we pass the flag -e "Node.connect(manager_node)". What if, instead, we called something like LXical.RemoteControl.connect_to_manager(manager_node) that was defined like this:
def connect_to_manager(manager) do
true = Node.connect(manager)
spawn(fn ->
Node.monitor(manager, true)
receive do
{:nodedown, ^manager} -> System.stop()
end
end)
endThoughts?
| end | ||
|
|
||
| @impl true | ||
| def handle_info({:nodedown, _}, state) do |
There was a problem hiding this comment.
I think state is the manager node here, maybe this is worth doing?
Suggested change
| def handle_info({:nodedown, _}, state) do | |
| def handle_info({:nodedown, manager}, manager) do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, our script that's designed to clean up after the project node port doesn't seem to work correctly. Because of this, it makes sense to monitor the manager node for the project node and to shut down when the manager node dies.