Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: allow setting a subset of configuration #297

Open
codeclown opened this issue Jan 19, 2020 · 1 comment
Open

Feature suggestion: allow setting a subset of configuration #297

codeclown opened this issue Jan 19, 2020 · 1 comment

Comments

@codeclown
Copy link

For my project I had to set a custom value for httpPort in pebble-config.json.

Currently in my custom JSON I need to specify the rest of the configuration as well:

{
  "pebble": {
    "listenAddress": "0.0.0.0:14000",
    "managementListenAddress": "0.0.0.0:15000",
    "certificate": "test/certs/localhost/cert.pem",
    "privateKey": "test/certs/localhost/key.pem",
    "httpPort": 80,
    "tlsPort": 5001,
    "ocspResponderURL": "",
    "externalAccountBindingRequired": false
  }
}

It would be convenient if I could omit all properties but the ones I need to modify. So my JSON would look like this:

{
  "pebble": {
    "httpPort": 80
  }
}

Pebble could pull the default values for the rest.

@cpu
Copy link
Contributor

cpu commented Jan 20, 2020

Seems like a reasonable request 👍 I probably won't have a chance to implement this short term but would accept a PR from the community.

AdamBark added a commit to AdamBark/pebble that referenced this issue Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants