Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit logging #49

Closed
wants to merge 2 commits into from
Closed

Audit logging #49

wants to merge 2 commits into from

Conversation

valerauko
Copy link

@valerauko valerauko commented Apr 23, 2021

Why?

Closes #47
In an enterprise context having an auditable log of SCIM requests is essential

What?

  • add option to configure request logging
  • log every request if logging is configured

Testing Notes

  • works with config.audit_logger unset
  • logs request if config.audit_logger is set to a class name string
  • logs request if config.audit_logger is set to something that responds to info

Todo

I'm planning to mark this "ready for review" once I add rspec test cases for the changes and fix any lint violations

Alternatives Considered

Since it just calls info with the request object, it isn't particularly useful with actual Logger instances. Maybe requiring some ScimRails specific interface would be better? (Along the lines of the on_error config option)

@valerauko valerauko closed this Nov 19, 2021
@valerauko valerauko deleted the audit branch November 19, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit logger
1 participant