Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buttons #71

Open
seagyn opened this issue Oct 16, 2019 · 2 comments
Open

Refactor buttons #71

seagyn opened this issue Oct 16, 2019 · 2 comments

Comments

@seagyn
Copy link
Contributor

seagyn commented Oct 16, 2019

The buttons need to be refactored to be easier to use and conform to the design system. There isn't a need to make them dynamic but we do need to be able to override styles from the consumer (const NewButton = styled(Button)).

https://www.figma.com/file/bUBZY5aVyXYdedy2wCtDxr/Oxygen-Core?node-id=0%3A844

This might require the creation of a more elaborate and descriptive naming convention:

Primary, Secondary, Outline, Text

with props like noShadow, icon, disabled etc.

@chrysillala
Copy link

hi @seagyn , let me help you on this issue

@jenniferharmon
Copy link

hi @seagyn I have created a PR (#74) with some refactoring and additional button features (hover and active states, icons and icon/loader positioning). I hope it makes it easy to create buttons that conform to the style guide and also to customize styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants