[CLI] videodownload: Calculate percentage in "Finalizing Video" by file size

[superbonaci]

Checklist

• I have checked the issue page for duplicates
• I am running the latest version (download here)

Edition

Unsure

Describe your issue here

Step 5/5 in most cases only displays the 3 dots instead of the real percentage:

TwitchDownloaderCLI videodownload -u 2065608792 -o 2065608792.mp4
TwitchDownloaderCLI 1.54.1 Copyright (c) lay295 and contributors
[STATUS] - Fetching Video Info [1/5]
[STATUS] - Downloading 100% [2/5]
[STATUS] - Verifying Parts 100% [3/5]
[STATUS] - Combining Parts 100% [4/5]
[STATUS] - Finalizing Video... [5/5]
[STATUS] - Finalizing Video 100% [5/5]

All the percent values are 2147483647 except the first which is 0 and the last is 100. My feature request is to compare the file size of the output to output.ts file size, and use that as percent for mp4. For .m4a adjust also.

Add any related files or extra information here

No response

[ScrubN]

The size of the final mp4 is different from the size of the combined ts (and frankly I want to rewrite finalization so combining is never performed) so this is not plausible. Believe me, I tried to find a correlation between the ts and mp4 file sizes for #770 but did I could not find a pattern, hence the language "may not".

I'd rather try to fix the root issue, however I have never been able to reproduce the out of bounds percent values so I cannot debug anything.

[ScrubN]

Also, reading from ffmpeg stdout is much cheaper than making fs calls.

[superbonaci]

The issue comes from this line:

double seekDuration = Math.Round(downloadOptions.CropEndingTime - downloadOptions.CropBeginningTime);

if the user doesn't set -e to the video duration it will be 0.

[superbonaci]

I'll add a fix to the PR if I find how to fix it.

[ScrubN]

#1004 fixes the root issue that causes the -2147483648% percent

[ScrubN]

Because audio encoding is non-deterministic, this will probably never be possible with the same or better accuracy than parsing the timecode from FFmpeg stdout.