Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlining dependencies #166

Open
tansaku opened this issue May 16, 2019 · 2 comments
Open

inlining dependencies #166

tansaku opened this issue May 16, 2019 · 2 comments

Comments

@tansaku
Copy link

tansaku commented May 16, 2019

Apologies if this is the wrong place for this question, but is Uglifier involved in the inlining dependencies of node_modules?

I'm trying to work out how sprockets does this, and I'm unclear how Uglifier is involved. I have a situation where inlining of dependencies is done differently on my machine and on a remote server. More details of that here: rails/sprockets#602

Superficially I assume that sprockets does the dependency management then Uglifier runs as a follow up step, but if anyone could clarify that would be great. If uglifier is involved is there a setting to control how dependencies are merged into a single file?

@adam-ludgate
Copy link

@tansaku are you having issues with the ordering of the dependencies?
I opened a related issue #161
I'm made to understand that the ordering could be an issue with the UglifyJS library itself, and not the Ruby wrapper

@tansaku
Copy link
Author

tansaku commented Jun 25, 2019

@adam-ludgate it wasn't the ordering, it was that in some cases the dependencies were inlined and in others they were imported ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants