From beffe87f51ca2c9d1f66999309e39abdae15b0d8 Mon Sep 17 00:00:00 2001 From: Eli Bishop Date: Fri, 11 Jan 2019 12:39:40 -0800 Subject: [PATCH] correction, assemblies are not signed yet --- CHANGELOG.md | 2 -- README.md | 8 ++++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c57b250b..4c562cfc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,10 +4,8 @@ All notable changes to the LaunchDarkly .NET SDK will be documented in this file ## [5.6.0] - 2019-01-09 ### Added: - - There are now helper classes that make it much simpler to write a custom `IFeatureStore` implementation. See the `LaunchDarkly.Client.Utils` namespace. - The new `FeatureStoreCaching` class will be used by database feature store integrations in the future. It is not used by the SDK client itself. -- The published assemblies are now digitally signed, in addition to being strong-named. This also applies to the other three LaunchDarkly assemblies that it depends on. ### Changed: - Some support code has been moved into a separate assembly, [`LaunchDarkly.Cache`](https://github.com/launchdarkly/dotnet-cache). diff --git a/README.md b/README.md index 85ab6bf6..236d2dc0 100644 --- a/README.md +++ b/README.md @@ -40,12 +40,12 @@ Your first feature flag Database integrations --------------------- -Separate packages allow feature flag data to be cached with [Redis](https://github.com/launchdarkly/dotnet-client-redis) or [DynamoDB](https://github.com/launchdarkly/dotnet-client-dynamodb) (see links for more information and source code). Other database integrations may be available in the future; see ["Using a persistent feature store"](https://docs.launchdarkly.com/v2.0/docs/using-a-persistent-feature-store). +Separate packages allow feature flag data to be cached with [Redis](https://github.com/launchdarkly/dotnet-client-redis), [DynamoDB](https://github.com/launchdarkly/dotnet-client-dynamodb), or [Consul](https://github.com/launchdarkly/dotnet-client-consul). See ["Using a persistent feature store"](https://docs.launchdarkly.com/v2.0/docs/using-a-persistent-feature-store) for more information. Using flag data from a file --------------------------- -For testing purposes, the SDK can be made to read feature flag state from a file or files instead of connecting to LaunchDarkly. See `LaunchDarkly.Client.Files.FileComponents` for more details. +For testing purposes, the SDK can be made to read feature flag state from a file or files instead of connecting to LaunchDarkly. See `LaunchDarkly.Client.Files.FileComponents` and ["Reading flags from a file"](https://docs.launchdarkly.com/docs/reading-flags-from-a-file) for more details. DNS caching issues ------------------ @@ -72,7 +72,7 @@ See [Contributing](https://github.com/launchdarkly/dotnet-client/blob/master/CON Signing ------- -The published version of the `LaunchDarkly.Client` assembly is digitally signed by LaunchDarkly. It is also [strong-named](https://docs.microsoft.com/en-us/dotnet/framework/app-domains/strong-named-assemblies); the public key file is in this repo at `LaunchDarkly.pk` as well as here: +The published version of the `LaunchDarkly.Client` assembly is [strong-named](https://docs.microsoft.com/en-us/dotnet/framework/app-domains/strong-named-assemblies); the public key file is in this repo at `LaunchDarkly.pk` as well as here: ``` Public Key: @@ -85,7 +85,7 @@ edc64131a9efeefd20978dc58c285aa6f548a4282fc6d871fbebeacc13160e88566f427497b625 Public Key Token: f86add69004e6885 ``` -Building the code locally in the default Debug configuration does not sign the assembly and does not require a key file. +Building the code locally in the default Debug configuration does not use strong-naming and does not require a key file. Development notes -----------------