Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about how to add new models #29

Open
lgeiger opened this issue Jul 12, 2019 · 2 comments
Open

Add documentation about how to add new models #29

lgeiger opened this issue Jul 12, 2019 · 2 comments
Assignees
Labels
documentation Issues related to documentation

Comments

@lgeiger
Copy link
Member

lgeiger commented Jul 12, 2019

No description provided.

@lgeiger lgeiger added the documentation Issues related to documentation label Jul 12, 2019
@lgeiger lgeiger self-assigned this Jul 12, 2019
@AdamHillier
Copy link
Contributor

The method we are currently using to host weights as GitHub release assets is not bad, but we do need to be a bit careful with it.

Each time we trigger a new release to host the weights files we end up triggering our publish action, which tries to publish a new version to PyPI. This fails only because PyPI rejects a package with the same version number in setup.py.

See here for an example.

@lgeiger
Copy link
Member Author

lgeiger commented Apr 17, 2020

Thanks for catching it.

Hmm this should prevent running the publish action on tags that don't start with v

Looks like #131 introduced this regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues related to documentation
Projects
None yet
Development

No branches or pull requests

2 participants